Json file generation build #1072
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not needed for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to have json generated files in the repo and to make sure that the correct version of re2c is used. The performance of JSON extension is dependent on their tools. In addition (and more importantly) there is a future possibility to increase the version to 0.13.7+ and use native UTF-8 re2c implementation which would simplify the scanner considerably.
However such restriction could be inconvenient for many users that prefer to use distro version of the re2c. For that reason the generation of re2c and bison files will be optional only if the user configure PHP with
--enable-json-filegenoption. There is absolutely no need to enable that option if the user don't want to change something in the parser or scanner (which will 99% of users and that 1% is probably just myself :) ). When the options is not enabled, the files in repository are used. That also means that there won't be any conflicts because the files simply won't be regenerated.