Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix zend_compile_func_decl scope #10794

Closed
wants to merge 1 commit into from
Closed

Fix zend_compile_func_decl scope #10794

wants to merge 1 commit into from

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Mar 6, 2023 •
edited

fix #10782

discussion #10782 (comment)

@mvorisek
Copy link
Contributor Author

mvorisek commented Mar 6, 2023 •
edited

@bwoebi with opcache, I get the following failure then:

 ========DIFF========
001+ string(4) "A::C"
001- string(4) "B::C"
========DONE========
FAIL self:: class constants should not be propagated into closures, due to scope
rebinding [Zend/tests/no_class_const_propagation_in_closures.phpt]

@mvorisek
Copy link
Contributor Author

I do not have enough internals knowledge to fix this by myself.

@mvorisek mvorisek closed this May 18, 2023
@mvorisek mvorisek deleted the fix_closure_compile_scope branch May 18, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mvorisek