Fix GH-10406: feof() behavior change for UNIX based socket resources #10877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @MaxKellermann @cmb69 @Girgias @nielsdos as you were commenting on that bug. |
|
I'm not very familiar with this part of PHP, but the concept makes sense. |
Girgias
approved these changes
Mar 20, 2023
|
Check out the Windows failure, this test should be skipped for non-unix(like). |
bukka
force-pushed
the
stream_socket_server_eof
branch
from
6d192f3
to
0b8d433
Compare
Girgias
approved these changes
Mar 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #10406 that happened due to 2d98631 . As discussed in the bug it does not make sense to call feof for the server but it previously resulted in poll being called which changed so the return value changed as well.
This PR keeps the old behaviour for the server socket streams that don't support IO. This is now stored in the stream flags so it can be later used to do some other decisions and possibly introduce some better error reporting. For now we should just keep the pre 8.2 behaviour as it was an unintended change without any note in UPGRADING and the new behaviour does not make things better.