Add new test for array_fill() to cover the case when the parameter count is too large

[jquiaios]

I added a new test to cover an untested case in the array_fill() function.

Before

After

[iluuu1994]

@jquiaios Thank you for your contribution! Not sure if we really need this test. Tests that use huge amounts of memory can influence other tests that run in parallel in CI, our CI is already very flaky. On 32-bit your test fails because int to float promotion happens on "INT32_MAX" + 1.

[jquiaios]

@mvorisek @iluuu1994 Thank you both for your feedback. What do you recommend then? Should I try to divide this test into two, one testing the x32 and the other x64? Or just forget about this test to avoid making the CI flakier ?

Also if you have any recommendation about other functionalities to test instead of these kinds of very edge cases, please let me know, I'm new to contributing and any advice to improve the experience is good to take.

[iluuu1994]

Right, on 32-bit this error can't occur because INT32_MAX + 1 overflows to float and leads to a type error. Thus the test needs to be skipped for 32-bit. This can be done with if (PHP_INT_SIZE != 8) die("skip: 64-bit only"); in the SKIPIF section.

The test is actually fine, it doesn't allocate any memory, it fails before doing so. So this should impact other tests. 👍

[iluuu1994]

Great, thank you @jquiaios!