Fix bug #81642: DOMChildNode::replaceWith() bug when replacing a node with itself #11363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le namespaces The test was amended from the original issue report. For the test: Co-authored-by: php@deep-freeze.ca The problem is that the regular dom_reconcile_ns() only works on a single node. We actually have to reconciliate the whole tree in case a fragment was added. This also required to move some code around such that this special case could be handled separately.
Girgias
approved these changes
Jun 4, 2023
| @@ -1251,8 +1251,7 @@ PHP_METHOD(DOMElement, replaceWith) | |||
| id = ZEND_THIS; | |||
| DOM_GET_OBJ(context, id, xmlNodePtr, intern); | |||
|
|
|||
| dom_parent_node_after(intern, args, argc); | |||
| dom_child_node_remove(intern); | |||
| dom_child_replace_with(intern, args, argc); | |||
There was a problem hiding this comment.
Unrelated, but the argc variable should be of type uint32_t
There was a problem hiding this comment.
Yeah, something for a follow-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs (and based on) PR GH-11362 . I will rebase this once that PR is merged.
Fixes #81642
After the fixes I did recently, the above bug no longer hangs, but still produces the wrong result for the first case. This is because the algorithm that is used for replaceWith isn't entirely correct: if the node becomes a part of the fragment, then removing the node actually removes the fragment. This results in the sudden removal of the node instead of replacing it.
I had to move some code around to be able to detect this.