Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mbstring count_demerits in reverse order #11493

Merged
merged 1 commit into from Jun 21, 2023
Merged

mbstring count_demerits in reverse order #11493

merged 1 commit into from Jun 21, 2023

Conversation

iluuu1994
Copy link
Member

This way we can avoid moving candidates that would be eliminated after.

@iluuu1994
mbstring count_demerits in reverse order
b6defad 
This way we can avoid moving candidates that would be eliminated after.
alexdowad
alexdowad approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@alexdowad alexdowad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks very much for the improvement!

@iluuu1994 iluuu1994 merged commit 6c015ae into php:master Jun 21, 2023
12 of 13 checks passed
@iluuu1994
Copy link
Member Author

@alexdowad Thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexdowad alexdowad alexdowad approved these changes

Assignees
No one assigned
Labels
Extension: mbstring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iluuu1994 @alexdowad