number_format: No precesion loss on formatting int's #11584
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #11487 supporting negative decimal places on
number_format
.number_format
will perform formatting the int (zend_long
) value without casting it to float (double
)zend_ulong
to be able to round high numbers without integer overflow (e.g.9223372036854775806
->10,000,000,000,000,000,000
)zend_long
for decimals (dec
argument) as there is a possible integer overflow with big numbers. This issue still exists on formatting floats but fixing it would be a BC break. (opened a separate PR number_format: prevent integer overflow on big decimal number #11649)PS: I'm not a C developer and this is the first time for me handling pointers and malloc ... please review carefully that I haven't done a mistake ending up in crashes :)