Fix uouv on oom on object allocation #11844
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluuu1994
force-pushed
the
gh-11734
branch
2 times, most recently
from
df03193
to
bde616c
Compare
iluuu1994
force-pushed
the
gh-11734
branch
2 times, most recently
from
3488814
to
b74b19a
Compare
iluuu1994
force-pushed
the
gh-11734
branch
4 times, most recently
from
f39e7e4
to
5de708e
Compare
We may OOM during object initialization. In this case, free_obj needs to guard against NULL values. There may be more cases where this is an issue, these were the ones I was able to discover via script. Fixes phpGH-11734
Girgias
approved these changes
Aug 10, 2023
|
|
||
| /* dbh might be null if we OOMed during object initialization. */ | ||
| if (!dbh) { | ||
| return; |
There was a problem hiding this comment.
Nit: double indent
Suggested change
| return; | |
| return; |
|
Merged as ee000ea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
free_obj can run before the object is fully initialized, requiring guards for potentially unset fields.
Fixes GH-11734