Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always throw TypeException on throwing zpp failures #1215

Closed
wants to merge 1 commit into from
Closed

Always throw TypeException on throwing zpp failures #1215

wants to merge 1 commit into from

Commits on Apr 3, 2015

  1. Always throw TypeException on throwing zpp failures 

    Introduces a ZEND_PARSE_PARAMS_THROW flag for zpp, which forces to
report FAILURE errors using a TypeException instead of a Warning,
like it would happen in strict mode.

Adds a zend_parse_parameters_throw() convenience function, which
invokes zpp with this flag.

Converts all cases I could identify, where we currently have
throwing zpp usage in constructors and replaces them with this API.
Error handling is still replaced to EH_THROW in some cases to handle
other, domain-specific errors in constructors.
    @nikic
    nikic committed Apr 3, 2015
    Copy the full SHA
    02359e9 View commit details
    Browse the repository at this point in the history