Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ifunc checks on FreeBSD 12+ #12288

Closed
wants to merge 1 commit into from

Conversation

Freaky
Copy link
Contributor

@Freaky Freaky commented Sep 23, 2023

This was disabled in 2019 due to problems reported in FreeBSD 11. The original report (PHP bug 77284) includes a comment that FreeBSD 12 worked - which also happens to be the first version ifunc use appeared in libc.


A similar patch is currently in FreeBSD ports lang/php83, but backporting to earlier versions will only be done if nothing crops up.

This was disabled in 2019 due to problems reported in FreeBSD 11. The original
report (PHP bug 77284) includes a comment that FreeBSD 12 worked - which also
happens to be the first version ifunc use appeared in libc.
@Freaky
Copy link
Contributor Author

Freaky commented Sep 23, 2023

This was requested in #12273.

@Freaky
Copy link
Contributor Author

Freaky commented Sep 23, 2023

(I also welcome guidance if there's a better way of doing this!)

@devnexen devnexen requested a review from petk September 23, 2023 20:11
@5u623l20
Copy link
Contributor

With my hat of the php maintainer in the FreeBSD ports tree @Freaky I think you can also safely remove the comment about FreeBSD 12. As of now any FreeBSD versions prior to 12 are not supported as they have reached EOL and in fact 12 will reach EOL in end of this year.

@devnexen
Copy link
Member

With my hat of the php maintainer in the FreeBSD ports tree @Freaky I think you can also safely remove the comment about FreeBSD 12.

While this makes no sense in the freebsd ports context indeed, however in our side it does since as mentioned in the ticket we have at least a FreeBSD 9.2 user, it's fair to assume there is other FreeBSD pre-12 users around, EOL or not.

@devnexen
Copy link
Member

ping @petk :)

Copy link
Member

@petk petk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, @Freaky. Sounds good to me to merge this with version for now. We can remove this in the future. No worries about the FreeBSD versions less than 12 not being supported anymore upstream. We still have some UNIX System V here and there in this build system noted :D But it's being cleaned on the regular basis.

@devnexen devnexen closed this in b90c9ca Dec 11, 2023
@devnexen
Copy link
Member

Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants