Restore old namespace reconciliation behaviour #12308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
approved these changes
Sep 27, 2023
Comment on lines
-1
to
-5
| --TEST-- | ||
| Bug #47847 (importNode loses the namespace of an XML element) | ||
| --EXTENSIONS-- | ||
| dom | ||
| --FILE-- |
There was a problem hiding this comment.
Possibly keep the tests but just mark them as XFAIL with a link to this PR to explain rationale for the revert?
| @@ -1489,11 +1489,15 @@ static void dom_reconcile_ns_internal(xmlDocPtr doc, xmlNodePtr nodep, xmlNodePt | |||
|
|
|||
| static void dom_libxml_reconcile_ensure_namespaces_are_declared(xmlNodePtr nodep) | |||
| { | |||
| #if 0 | |||
There was a problem hiding this comment.
Maybe add a comment to explain why this code is dead?
|
Fixed the remarks in the merge, thanks for checking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
xmlDOMWrapReconcileNamespacesmethod we used to fix the namespace corruption issues in 8.1.21/8.2.8 caused regressions. Primarily, there is a similar corruption that thexmlReconciliateNsmethod used to have in which a namespace is suddenly shifted (SAML-Toolkits/php-saml#562) and the side-effect of removing redundant namespaces causes problems when a specific serialization is required.REMINDER FOR SELF: there's an additional reconciliation in the lifetime management code in PHP>=8.3!
This means the following issues will re-open:
For now, restore the old behaviour while we think of a general solution (e.g. something related with opt-in using the new classes).