Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typed constants in PDO extension #12362

Merged
merged 3 commits into from Oct 29, 2023
Merged

Typed constants in PDO extension #12362

merged 3 commits into from Oct 29, 2023

Conversation

jorgsowa
Copy link
Contributor

@jorgsowa jorgsowa commented Oct 4, 2023

This PR adds the types to the constants in PDO extension.

kocsismate
kocsismate reviewed Oct 6, 2023
View reviewed changes
Copy link
Member

@kocsismate kocsismate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well, but I'm curious about the opinion of others

kocsismate
kocsismate reviewed Oct 8, 2023
View reviewed changes
ext/pdo/pdo_dbh.stub.php
@@ -5,311 +5,163 @@
/** @not-serializable */
class PDO
{
/**
* @cvalue LONG_CONST(PDO_PARAM_NULL)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

@jorgsowa jorgsowa force-pushed the typed-constants-in-pdo-extension branch from 180d664 to 4756ced Compare October 28, 2023 19:17
@kocsismate kocsismate merged commit dff8679 into php:master Oct 29, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kocsismate kocsismate kocsismate approved these changes

Assignees
No one assigned
Labels
Extension: pdo (core)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jorgsowa @kocsismate