Fix bug #75708: getimagesize with "&$imageinfo" fails on StreamWrappers #12444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bukka
force-pushed
the
image_jpg_read_all_chunks
branch
from
c2c2bfd
to
e006ad5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When jpeg image with large (over stream chunk size) APP data (e.g. large metadata comment) is loaded, then not all data will be read in a single read for user stream wrapper which does not use greedy reading like for example file wrapper.
This PR makes sure that that if the whole chunk is read, then another chunk is attempted to be read until less than one chunk or whole stream is read.