[pdo_firebird] Added pdo_firebird_check_liveness
#12757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SakiTakamachi
force-pushed
the
pdo-firebird-liveness
branch
2 times, most recently
from
28d8d6d
to
e34305d
Compare
SakiTakamachi
force-pushed
the
pdo-firebird-liveness
branch
2 times, most recently
from
6f5e79d
to
7cb0aba
Compare
SakiTakamachi
force-pushed
the
pdo-firebird-liveness
branch
from
7cb0aba
to
5d1331a
Compare
SakiTakamachi
changed the title
pdo_firebird_check_liveness
SakiTakamachi
commented
Dec 15, 2023
Comment on lines
+1219
to
+1229
| #if FB_API_VER >= 30 | ||
| /* called by PDO to check liveness */ | ||
| static zend_result pdo_firebird_check_liveness(pdo_dbh_t *dbh) /* {{{ */ | ||
| { | ||
| pdo_firebird_db_handle *H = (pdo_firebird_db_handle *)dbh->driver_data; | ||
|
|
||
| /* fb_ping return 0 if the connection is alive */ | ||
| return fb_ping(H->isc_status, &H->db) ? FAILURE : SUCCESS; | ||
| } | ||
| /* }}} */ | ||
| #endif |
There was a problem hiding this comment.
I downloaded the source from the following list and checked the included ibase.h:
https://firebirdsql.org/en/discontinued-versions/
It turns out that this feature was introduced since v3.0.
|
@Girgias |
Girgias
approved these changes
Dec 20, 2023
|
Thank you for checking! Please wait a moment. |
|
Added to UPGRADING! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added liveness check function for persistent connections.
todo: