Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix segfault in ZEND_BIND_STATIC #12758

Closed
wants to merge 6 commits into from
Closed

fix segfault in ZEND_BIND_STATIC #12758

wants to merge 6 commits into from

Commits on Nov 23, 2023

  1. fix segfault in ZEND_BIND_STATIC 

    In case a `ZEND_BIND_STATIC` is being executed, while the current chunk is full,
the `zend_array_dup()` call will trigger a OOM in ZendMM which will crash, as
the opline might be a dangling pointer.
    Florian Engelhardt committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    3056f4c View commit details
    Browse the repository at this point in the history

  2. add missing test

    @realFlowControl
    realFlowControl committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    0fcb4e4 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2023

  1. assert()ing seems easier than trying to make the compiler to not op… 

    …timize
    @realFlowControl
    realFlowControl committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    0e40a22 View commit details
    Browse the repository at this point in the history

  2. moved from function call to INI setting, so we can use this in other … 

    …places as well
    @realFlowControl
    realFlowControl committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    2449f9e View commit details
    Browse the repository at this point in the history

  3. make assert() work no NDEBUG builds

    @realFlowControl
    realFlowControl committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    c559eae View commit details
    Browse the repository at this point in the history

  4. document magic number

    @realFlowControl
    realFlowControl committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    516ea04 View commit details
    Browse the repository at this point in the history