Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Add mb_ucfirst and mb_lcfirst functions #13161

Merged
merged 15 commits into from
Mar 20, 2024
Merged

[RFC] Add mb_ucfirst and mb_lcfirst functions #13161

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
959f9f5
Add mb_ucfirst and mb_lcfirst functions
youkidearitai Jan 16, 2024
d10721c
merge functions
youkidearitai Jan 17, 2024
09a3f9b
Change from zend_string_release to zend_string_release_ex
youkidearitai Jan 17, 2024
55d7de5
Fix mb_ucfirst from MB_CASE_UPPER to MB_CASE_TITLE
youkidearitai Feb 2, 2024
861209f
Add test case to Georgian word to mb_ucfirst
youkidearitai Feb 8, 2024
555eb20
Add NEWS and UPGRADING
youkidearitai Mar 7, 2024
8a007f0
Refactor php_mb_ulcfirst
youkidearitai Mar 7, 2024
7786571
If is not need convert, use zend_string_copy.
youkidearitai Mar 7, 2024
31c6620
Fix zend_string_release
youkidearitai Mar 7, 2024
4472ef1
Fix RETURN_STR instead of RETVAL_STR
youkidearitai Mar 7, 2024
e6cc1e2
Improve and optimize variable second move after if statement
youkidearitai Mar 7, 2024
aa58c7f
fix a nit
youkidearitai Mar 8, 2024
c55d7b2
Add test case for ASCII and SJIS (other encoding)
youkidearitai Mar 14, 2024
216e104
Add test case for longer strings
youkidearitai Mar 14, 2024
7231969
Add test case for EUC-JP
youkidearitai Mar 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ext/mbstring/mbstring.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2973,7 +2973,10 @@ static void php_mb_ulcfirst(INTERNAL_FUNCTION_PARAMETERS, php_case_mode mode)
zend_string *head = mbstring_convert_case(mode, ZSTR_VAL(first), ZSTR_LEN(first), enc);

if (zend_string_equals(first, head)) {
RETVAL_STR(zend_string_copy(str));
zend_string_release_ex(first, false);
zend_string_release_ex(head, false);
zend_string_release_ex(second, false);
youkidearitai marked this conversation as resolved.
Show resolved Hide resolved
RETURN_STR(zend_string_copy(str));
}

zend_string_release_ex(first, false);
Expand Down
Loading