FIX file_get_contents() on Windows fails with "errno=22 Invalid argument"

[DnwK98]

I encountered a problem when attempting to load a large file using file_get_contents(), but only on Windows.

Attempting to load a large file resulted in the following error (or notice, depending on the PHP version):

Read of 3866046082 bytes failed with errno=22 Invalid argument

I did some research and found bug which was quite similar, but for file_put_contents()

Old bug: #13205

This issue is likely due to an integer overflow on Windows, which probably is treated as negative number which is invalid argument.

[mvorisek]

👍 documented in https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/read?view=msvc-170

if buffer_size > INT_MAX, the invalid parameter handler is invoked

should target bugfix branch

[DnwK98]

Targets PHP-8.2

[devnexen]

Nice catch. I think it is possible to simplify line 356/360, what do you think ?

[devnexen]

I do not get your "revert" :) previous version was fine I think.

[DnwK98]

It wasn't, as windows uses _read() and others systems uses read()

I also didn't see this at the beginning.

[devnexen]

oh I did not see the inconsistency between _write/write and read

[devnexen]

LCTM

[bukka]

It needs a test - otherwise look ok.

[DnwK98]

I updated test created in previous ticket, but I'm also not able to run it against Windows.

[bukka]

PASS means that you were able to run it and it was fine. If it wasn't run, it would be a skip. Or is the screen shot not from Windows (the test should work also on Linux and other platforms with enough memory)?

[DnwK98]

I don't have computer with Windows, also test skips on CI as was suggested in previous bug. You @bukka were person who ran test on Windows locally previously, so if you could also now, I'll be pleased.

Edit: This test is not skipped on CI as was suggested, so I did test without fix and it failed as expected. After fix it succeed.

[bukka]

Tested on Windows and works fine