cli: allow to change ~/.php_history with PHP_HISTFILE #13964
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related: #8546 |
spk
force-pushed
the
php-histfile-env
branch
2 times, most recently
from
1b9dfc5
to
055fd8a
Compare
iluuu1994
reviewed
Apr 18, 2024
sapi/cli/tests/017.phpt
Outdated
| $dir = PHP_OS_FAMILY == 'Windows' ? getenv("USERPROFILE") : getenv("HOME"); | ||
| var_dump(file_exists($dir . '/.php_history')); | ||
|
|
||
| define("TMPDIR", __DIR__ . "/"); | ||
| $php_history_tmp = TMPDIR . "php_history"; |
There was a problem hiding this comment.
Please use $php_history_tmp = tempnam(sys_get_temp_dir(), 'php_history'); to avoid having to clean up the file and putting it in the ignore list.
Edit: Or just sys_get_temp_dir() . '/php_history', as tempnam will create an empty file.
There was a problem hiding this comment.
Thanks i've applied the changes, current CI failure doesn't look related
spk
force-pushed
the
php-histfile-env
branch
2 times, most recently
from
ee1a2e0
to
609429d
Compare
|
Merged as 3f0b204. (Linked the wrong PR...) |
|
Thank you @spk! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why
Allow to change .php_history repl file with PHP_HISTFILE environment variable
how
If the env var is present use it first then fallback to HOME or USERPROFILE on windows
(i'm not a C developer any help/feedback welcome thanks)