Remove unused ext/spl SPL_API code #13985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ext/spl is always enabled and building it as shared is no longer relevant.
Girgias
approved these changes
Apr 17, 2024
|
Ah, I see. Making ext/spl shared again would be almost impossible at this point, I think. Because so much code now relies to the iterators, interfaces and everything in it that I'm not sure how that would work :D |
|
I've merged this. In case the change will be needed at some point in the future to reintroduce the ext/spl as shared or to refactor it, then that SPL_API parts can be added back... Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ext/spl is always enabled and building it as shared is no longer relevant.