Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GH-13998: Manage refcount of agg_context->val correctly #14004

Closed
wants to merge 2 commits into from
Closed

Fix GH-13998: Manage refcount of agg_context->val correctly #14004

wants to merge 2 commits into from

Conversation

SakiTakamachi
Copy link
Member

@SakiTakamachi SakiTakamachi commented Apr 19, 2024 •
edited

fixes #13998

@SakiTakamachi SakiTakamachi changed the title Fix GH-13998 WIP Fix GH-13998: add_next_index_string is no longer called when the number of characters in errmsg is 0 Apr 19, 2024
@SakiTakamachi SakiTakamachi changed the title Fix GH-13998: add_next_index_string is no longer called when the number of characters in errmsg is 0 Fix GH-13998: If length of errmsg is 0, do not call add_next_index_string Apr 19, 2024
@SakiTakamachi SakiTakamachi changed the title Fix GH-13998: If length of errmsg is 0, do not call add_next_index_string Fix GH-13998: Manage refcount of agg_context->val correctly Apr 19, 2024
@SakiTakamachi
Manage refcount of agg_context->val correctly
a3a2e02 
When step_callback fails, agg_context->val is passed dtor, but agg_context->val
is also used in final_callback regardless of the success/failure of step_callback,
so should not call dtor.
@SakiTakamachi SakiTakamachi marked this pull request as ready for review April 19, 2024 13:52
@SakiTakamachi SakiTakamachi changed the base branch from master to PHP-8.2 April 19, 2024 14:45
arnaud-lb
arnaud-lb approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@arnaud-lb arnaud-lb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

SakiTakamachi added a commit that referenced this pull request Apr 20, 2024
@SakiTakamachi
Merge branch 'PHP-8.2' into PHP-8.3
4306416 
* PHP-8.2:
  Fix GH-13998: Manage refcount of agg_context->val correctly (#14004)
SakiTakamachi added a commit that referenced this pull request Apr 20, 2024
@SakiTakamachi
Merge branch 'PHP-8.3'
3e3875c 
* PHP-8.3:
  Fix GH-13998: Manage refcount of agg_context->val correctly (#14004)
@SakiTakamachi SakiTakamachi deleted the fix/gh-13998 branch April 20, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaud-lb arnaud-lb arnaud-lb approved these changes

@nielsdos nielsdos nielsdos approved these changes

Assignees
No one assigned
Labels
Extension: pdo_sqlite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Member access within misaligned address in zend_alloc.c
3 participants
@SakiTakamachi @arnaud-lb @nielsdos