Fix tests for glibc 2.39 #14097
Merged
Fix tests for glibc 2.39 #14097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.39 has fixed inconsistent (mon_)grouping formats in localedata: * https://sourceware.org/git/?p=glibc.git;a=blob;f=NEWS;hb=refs/tags/glibc-2.39#l237 * https://sourceware.org/git/?p=glibc.git;a=blob;f=localedata/locales/en_AU;hb=refs/tags/glibc-2.39#l65 For en_AU locale now it returns array of 1 item instead of 2 for grouping and mon_grouping. Since this is upstream change depending on the system, this only syncs tests for such case.
devnexen
approved these changes
Apr 30, 2024
Girgias
approved these changes
May 1, 2024
petk
added a commit
that referenced
this pull request
May 1, 2024
* PHP-8.2: Fix tests for glibc 2.39 (#14097)
petk
added a commit
that referenced
this pull request
May 1, 2024
* PHP-8.3: Fix tests for glibc 2.39 (#14097)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Glibc 2.39 has fixed inconsistent (mon_)grouping formats in localedata:
For en_AU locale now it returns array of 1 item instead of 2 for grouping and mon_grouping.
Since this is upstream change depending on the system, this only syncs tests for such case.
Steps to reproduce the issue: