No ext/com-dotnet resources #14282
Draft
No ext/com-dotnet resources #14282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 tasks
|
@cmb69 In case you are interested in the resource to object migration of ext/com_dotnet |
|
Will this still land for 8.4? |
I don't really care about this, I mainly made this PR to help Máté further because he wasn't familiar with Windows. |
|
I'll have a look at this (probably tomorrow). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I think that for these internal data structures, moving them away from resources has a downside: if for example a fatal error occurs during execution, then they won't be cleaned up now whereas they would've been cleaned up if they were resources.
Also need to check if the refcount can be > 0 at the end of script execution.