Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DBA_DB1 definition from Windows build #14649

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

petk
Copy link
Member

@petk petk commented Jun 23, 2024

The DBA_DB1 is checked with #ifdef and version 1 emulation is present in DB version 3.

Or if this should be defined (to 1 to be more clear and match the Autotools)...

The DBA_DB1 is checked with #ifdef and version 1 emulation is present in
DB version 3.
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we really should remove support for the old DBA handlers, as I don't think it's even possible to run them on modern hardware without going through the effort of self compiling it.

@petk
Copy link
Member Author

petk commented Jun 24, 2024

LGTM, we really should remove support for the old DBA handlers, as I don't think it's even possible to run them on modern hardware without going through the effort of self compiling it.

Ok. Yes, this could be cleaned up in the near future. I'll check... Thanks for the info.

@petk petk merged commit 3da6377 into php:master Jun 24, 2024
9 of 11 checks passed
@petk petk deleted the patch-windows-DBA_DB1 branch June 24, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants