Fix negation in shell tests #14662
Merged
Fix negation in shell tests #14662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to documentation the `if test ! ...` is preferred to `if ! test ...`. The later is not portable: https://www.gnu.org/software/autoconf/manual/autoconf-2.72/autoconf.html
Girgias
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to documentation the
if test ! ...is preferred toif ! test .... The later is not portable:https://www.gnu.org/software/autoconf/manual/autoconf-2.72/autoconf.html
(Manual currently doesn't show up, some work on the server probably, but it's written under portability of using test in ifs).