Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sapi/fpm: retiring solaris /dev/poll support proposal. #14685

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

devnexen
Copy link
Member

Since Solaris 10, the port API is supported, is more modern, less bug prone and offers, on average, better performances.

@devnexen devnexen marked this pull request as ready for review June 27, 2024 11:58
@devnexen devnexen requested a review from bukka as a code owner June 27, 2024 11:58
@devnexen
Copy link
Member Author

Not urgent, but I feel it s a low hanging fruit we really do not need anymore, Solaris 10 should be the minimum nowadays.

@petk
Copy link
Member

petk commented Jun 27, 2024

Ah, good one in this case. This is then Solaris<10 check only. If so, then this can definitely be removed. Even Solaris 10 is in the process of becoming obsolete. Building software on it is already quite a challenge and to build PHP on some hypothetical Solaris pre-10 version will be almost to near impossible, I believe. Or at least not without lots of custom builds of dependencies and even compiler itself. I think we can drop everything related to Solaris<10 and focus more on Solaris 11.4 and illumos support with optional Solaris 10 adjustments what can still be done.

I'm doing changes here #14681 and touching also this /dev/poll check. I hope it won't cause you issues to only rebase the PR... Thanks.

@devnexen
Copy link
Member Author

Yes I ve seen your PR no worries I ll manage :)

@bukka
Copy link
Member

bukka commented Jun 30, 2024

@devnexen There's actually one old bug for /dev/poll in bug tracker with 128 votes: https://bugs.php.net/bug.php?id=65774 . It mentions SmartOS but it's been over 10 years since created. Are you that /dev/poll is not used anywhere and it is safe to remove?

Since Solaris 10, the port API is supported, is more modern, less bug
prone and offers, on average, better performances.
@devnexen
Copy link
Member Author

devnexen commented Jun 30, 2024

I think so , no new report of usage since around 2013 indeed, this particular bug on solaris 10 from the ioctl DP_POLL part had been reported in other contexts like here, since Solaris and all flavor of Illumos support port api that would bring down to 1 native api per platform (beside poll/select). One less thing to update/clean for further php releases and so on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants