Remove mentions of "type hint" and "typehint" #1587
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changing code comments but not variable names seems inconsistent and might be confusing |
|
Changing more code seemed like it might be too much this close to release for 7.0. I would not object if we changed the code as well, though. |
|
Yeah, it has the potential to break things :/ Why didn't you change the test filenames, by the way? That's not going to break anything, and git can track renames just fine. |
|
I could rename the files too. I would do it in its own commit so it's clear they've only been moved. If I did it in the same commit then it would be harder to see the real diff. |
This does not rename variables or functions in C code, nor does it rename files or folders.
morrisonlevi
force-pushed
the
remove_type_hint_from_error_messages
branch
from
4c18ddb
to
7e40bfe
Compare
|
I pushed a commit to rename the files that I could find with "type hint" or "typehint" in their names. |
morrisonlevi
force-pushed
the
remove_type_hint_from_error_messages
branch
from
9a4d4cb
to
9cea4d2
Compare
|
merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously have removed some mentions of "type hint" in our documentation, and avoided it in some of our error messages. This removes the remaining usages in error messages. It also removes some usages in comments and in tests. This does not rename variables or functions in C code, nor does it rename files or folders.
If accepted it should also be applied to the next RC release of PHP 7.0.