Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring junit logger. Added generation of nested testsuites in junit.xml. #16

Closed
wants to merge 1 commit into from

Conversation

conf
Copy link
Contributor

@conf conf commented Mar 21, 2012

General intention:

  1. Refactor code operating with junit.xml.
  2. Implement nested testsuites so Jenkins won't list all tests on 1 page (which makes page very heavy) but nicely organizes them in groups. http://ci.qa.php.net now uses slightly older version of this patch and it went very well. See this page for example.

What was done:

  1. Much duplicated code was refactored into separate functions with junit_ prefix.
  2. Generation nested testsuites in junit.xml
  3. Some whitespace fixes. If you want to see patch without these changes try this url
    https://github.com/conf/php-src/compare/php:PHP-5.4...conf:run-tests-php-5.4?w=1 (like git diff -w)

@Tyrael
Copy link
Member

Tyrael commented Mar 23, 2012

for the record, I updated the run-tests.php on ci.qa.php.net to use this version, and it seems to work just fine.

@conf
Copy link
Contributor Author

conf commented Mar 27, 2012

Anybody from qa team here?

@cataphract
Copy link
Contributor

Since Tyrael was who wrote the junit functionality in the first place and he seems to approve, I've merged this into the official repository. Thanks.

@php-pulls
Copy link

Comment on behalf of cataphract at php.net:

Merged as 1e88d00.

@php-pulls php-pulls closed this Mar 28, 2012
@conf
Copy link
Contributor Author

conf commented Mar 29, 2012

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants