Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: array_change_keys #1925

Closed
wants to merge 6 commits into from
Closed

RFC: array_change_keys #1925

wants to merge 6 commits into from

Conversation

colinodell
Copy link
Contributor

colinodell and others added 6 commits May 27, 2016 23:04
@colinodell
Implement the array_change_keys() function
6e92f23
@colinodell
Fix duplicate key issue
6c9e469 
The original methods used could result in arrays containing duplicate keys.
For example, if you ran this code:

    array_combine([1, 2, 3], function(){ return 'foo'; });

You'd have three array elements with the same keys! Didn't even know that was possible.
@colinodell
Update warning message; make behavior consistent with array_flip
5844d9c
@colinodell
Add tests for array_change_keys
47136c2
@colinodell
Add missing line breaks to test
f368def
@jmikola @colinodell
Fix memory leaks in array_change_keys() (#1)
eae1ae3
laruence
laruence reviewed May 29, 2016
View reviewed changes
ext/standard/array.c
}

array_init_size(return_value, zend_hash_num_elements(Z_ARRVAL_P(array)));
params = (zval *)safe_emalloc(2, sizeof(zval), 0);
Copy link
Member

@laruence laruence May 29, 2016 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since the size is fixed, you could use stack allocated zval[2]

@smalyshev smalyshev added the RFC label Jun 14, 2016
@webdevxp
Copy link

webdevxp commented Jul 19, 2016 •
edited

Should this function be named array_map_key() or array_map_keys() for consistency with other array key related functions?
And because I think it's actually a variant of array_map() that operates on keys instead of values.
But to do so, argument list should match array_map() too.

array_map_key( callable $callback , array $array1 [, array $... ] )

This also make it appear next to array_map() in PHP manual.

@cmb69
Copy link
Contributor

cmb69 commented Nov 27, 2018

What's the status here? The RFC is still listed as being under discussion – are there unresolved issues?

@colinodell
Copy link
Contributor Author

Sorry, I've been meaning to withdraw this RFC and replace it with a different implementation, but never got around to fleshing that alternative out. I'll close it for now and post to the mailing list. Thanks for the ping!

@colinodell colinodell closed this Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
RFC Waiting on Author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@colinodell @webdevxp @cmb69 @laruence @smalyshev @jmikola