Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JUNIT support #2

Closed
wants to merge 2 commits into from
Closed

JUNIT support #2

wants to merge 2 commits into from

Conversation

Tyrael
Copy link
Member

@Tyrael Tyrael commented Nov 26, 2011

No description provided.

@Tyrael
Copy link
Member Author

Tyrael commented Nov 26, 2011

@Tyrael Tyrael closed this Nov 26, 2011
conf pushed a commit to conf/php-src that referenced this pull request Mar 21, 2012
…t is > 1.

  This reverts the fix for bug #24557.
- Make php_stream_free delete the stream from the resources list, not merely
  decrease its refcount, as a single call to zend_list_delete does.           
#Not worth the risk merging to 5.3. While change php#2 may prevent some segfaults,
#a quick and dirty survey to the codebase only showed calls to php_stream_close
#or php_stream_free on streams allocated in the same function, which would have
#refcount == 1. May be reconsidered.
conf pushed a commit to conf/php-src that referenced this pull request Mar 21, 2012
conf pushed a commit to conf/php-src that referenced this pull request Mar 21, 2012
php-pulls pushed a commit that referenced this pull request Mar 26, 2013
weltling referenced this pull request in weltling/php-src Jul 17, 2013
@Tyrael Tyrael mentioned this pull request Feb 20, 2014
moriyoshi referenced this pull request in moriyoshi/php-src Mar 15, 2014
…t is > 1.

  This reverts the fix for bug #24557.
- Make php_stream_free delete the stream from the resources list, not merely
  decrease its refcount, as a single call to zend_list_delete does.           
#Not worth the risk merging to 5.3. While change #2 may prevent some segfaults,
#a quick and dirty survey to the codebase only showed calls to php_stream_close
#or php_stream_free on streams allocated in the same function, which would have
#refcount == 1. May be reconsidered.


git-svn-id: http://svn.php.net/repository/php/php-src/php/php-src/trunk@309491 c90b9560-bf6c-de11-be94-00142212c4b1
moriyoshi referenced this pull request in moriyoshi/php-src Mar 15, 2014
morrisonlevi pushed a commit to morrisonlevi/php-src that referenced this pull request Apr 18, 2014
Added test for namespaced inheritance.
@ircmaxell ircmaxell mentioned this pull request Aug 21, 2014
laruence added a commit that referenced this pull request May 27, 2015
tpunt added a commit to tpunt/php-src that referenced this pull request Feb 2, 2016
pbowyer added a commit to pbowyer/php-src that referenced this pull request Jun 20, 2020
pbowyer added a commit to pbowyer/php-src that referenced this pull request Jun 20, 2020
MaxKellermann added a commit to CM4all/php-src that referenced this pull request Feb 7, 2023
Commit a211956 added a TSRM destructor, but that destructor
will get called by tsrm_shutdown(), which is after opcache.so has
already been unloaded, resulting in a shutdown crash, e.g.:

  #0  0x00007fad01737500 in ?? ()
  php#1  0x000055ac54e723c4 in tsrm_shutdown () at TSRM/TSRM.c:194
  php#2  0x000055ac54c42180 in main (argc=80, argv=0x55ac57bc14d0) at sapi/cli/php_cli.c:1388

By calling ts_free_id() before opcache.so gets unloaded, we can easily
fix this crash bug.
dstogov pushed a commit that referenced this pull request Feb 7, 2023
)

Commit a211956 added a TSRM destructor, but that destructor
will get called by tsrm_shutdown(), which is after opcache.so has
already been unloaded, resulting in a shutdown crash, e.g.:

  #0  0x00007fad01737500 in ?? ()
  #1  0x000055ac54e723c4 in tsrm_shutdown () at TSRM/TSRM.c:194
  #2  0x000055ac54c42180 in main (argc=80, argv=0x55ac57bc14d0) at sapi/cli/php_cli.c:1388

By calling ts_free_id() before opcache.so gets unloaded, we can easily
fix this crash bug.
dstogov referenced this pull request in dstogov/php-src Feb 13, 2023
In PHP-2.0 and below we by mistake returned "obcect(FFI\CData:void)#2 (0) {}".
We decided not to fix this in PHP-2.0 and below to aboid BC breaks.
dstogov added a commit that referenced this pull request Feb 14, 2023
In PHP-8.2 and below we by mistake returned "object(FFI\CData:void)#2 (0) {}". We decided not to fix this in PHP-8.2 and below to avoid BC breaks.
@HeavenCore HeavenCore mentioned this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant