Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug #71038 - session_start() returns true even when it failed #2167

Closed
wants to merge 24 commits into from
Closed

Fix bug #71038 - session_start() returns true even when it failed #2167

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
5ce7642
Fix bug #71038
Oct 16, 2016
fa6fa18
Add required return
Oct 17, 2016
637f72c
Since session_start() issue is fixed. Number of inconsistent behavior…
Oct 17, 2016
6ec20f2
Fix tests
Oct 17, 2016
bcf6764
Disallow nonsense INI changes
Oct 17, 2016
2a77f71
Update PHP_SESSION_API
Oct 17, 2016
29882f3
Remove env dependecy from test
Oct 17, 2016
bcae969
Add missing SUCCESS
Oct 17, 2016
27e4361
Use dedicated PHP_MH names. Align INI entry defs
Oct 18, 2016
f2d06e0
Base branch was wrong. Touch file to force travis to rebuild.
Oct 18, 2016
e7cd7c1
Check active state rather than http header. Check negative cookie lif…
yohgaki Oct 23, 2016
1cd9654
Merge branch 'PHP-7.1-session-bug71038' of github.com:yohgaki/php-src…
yohgaki Oct 23, 2016
3114f4d
Merge remote-tracking branch 'upstream/master' into PHP-7.1-session-b…
yohgaki Oct 23, 2016
1646d2f
Add doc. Check both output and active status. Changes after header se…
yohgaki Oct 23, 2016
f5bc23b
Update to more descrictive sentence
yohgaki Oct 23, 2016
7315a54
Fix test
yohgaki Oct 23, 2016
5a30738
I should have checked header sent status in functions, too.
yohgaki Oct 23, 2016
76f77f7
Add test for INI changes
yohgaki Oct 23, 2016
51e83df
Fix test
yohgaki Oct 23, 2016
94b5532
Merge branch 'master' into PHP-7.1-session-bug71038
Oct 24, 2016
3a1e707
Merge remote-tracking branch 'upstream/master' into PHP-7.1-session-b…
Oct 27, 2016
b96f304
Merge remote-tracking branch 'upstream/master' into PHP-7.1-session-b…
Oct 29, 2016
890a40f
Merge remote-tracking branch 'upstream/master' into PHP-7.1-session-b…
Nov 16, 2016
f9a39aa
Fix test
Nov 17, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions ext/session/php_session.h
View file
Open in desktop
Expand Up @@ -264,13 +264,13 @@ PHPAPI int php_session_register_serializer(const char *name,
int (*decode)(PS_SERIALIZER_DECODE_ARGS));

PHPAPI void php_session_set_id(char *id);
PHPAPI void php_session_start(void);
PHPAPI int php_session_start(void);

PHPAPI ps_module *_php_find_ps_module(char *name);
PHPAPI const ps_serializer *_php_find_ps_serializer(char *name);

PHPAPI int php_session_valid_key(const char *key);
PHPAPI void php_session_reset_id(void);
PHPAPI int php_session_reset_id(void);

#define PS_ADD_VARL(name) do { \
php_add_session_var(name); \
Expand Down