GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persistent connections skipped resetting $connect_error and $connect_errno values
This adds the "clear error" line to persistent connections for consistency
Fix Bug #73462 - Persistent connections don't set $connect_errno
The Travis CI environment is entirely unpredictable. Just pushed in a commit of just white-space change to the markdown file, and all compilation tests passed this time, vs failing randomly and arbitrarily before.
@darkain don't bother too much with Travis, I stopped caring much about it a while ago since as you mentioned, is way too inconsistent
this bugfix need a test, to be sure that it works fine.
what you think about?
Adding unit test for Bug #73462
More complete unit test for Bug #73462
The connection is now verified to be persistent when.
If the connection isn't persistent, then the bug wouldn't present itself anyways.
Comment on behalf of krakjoe at php.net:
Since this targets a security fix only branch of PHP, and since the author seems to have abandoned working on it anyway, I'm closing this PR.
Please take this action as encouragement to open a clean PR against a supported branch.
Doesn't look abandoned to me...
Also it appears to apply cleanly to master at least ... I'm sure I checked that ... my mistake ...
Merged via cfd6e14, thanks!