Test request47456.phpt for PR 1303 #2281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After merging PR 1303 unmatched subpatterns are set to NULL
|
Merged e55e93a (merged down to 7.0 ... in the most messy way possible ...) Thanks :) |
|
Why was a BC break merged down to |
|
This BC change was not merged down to PHP 7.0, It was an accident that this test was merged to the PHP-7.0 branch and it was quickly reverted before a release ever even happened. Take a look, the changes do not exist in the PHP-7.0 branch: Or you could look at this PR which reverts the merged test: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging #1303 unmatched subpatterns are set to NULL.
The test
ext/pcre/tests/request47456.phptwas created after the PR was created.