Namespace-scoped declares #2972
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The declares are not yet used for anything.
In order to consolidate all the (ordinary) declare state in one place.
Opcache support is still missing
Opcache now verifies that the namespaced declares during loading are the same as the ones during compilation, and invalidates the script if this isn't the case.
nikic
force-pushed
the
namespaceDeclare
branch
from
1fa6624
to
9f5a786
Compare
|
@nikic Is it ok to close this PR and the associated RFC? |
|
Yeah, don't plan any immediate work here. |
|
@nikic Thanks! I updated the RFC as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: https://wiki.php.net/rfc/namespace_scoped_declares
This PR adds support for the
namespace_declare()function:This will enable
strict_typesfor the namespaceFooand all sub-namespaces.