Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typed Properties #3313

Closed
wants to merge 420 commits into from
Closed

Typed Properties #3313

wants to merge 420 commits into from

Conversation

@nikic
Copy link
Member

@nikic nikic commented Jun 20, 2018

This is the implementation for the new typed properties RFC.

The implementation is not quite ready for review yet, there are still a number of open issues and some behavior edge-cases regarding references may still change.

dstogov added 30 commits May 25, 2016
…nversation with Joe)
…d_object_fetch_property_type_info_ex() into zend_object_fetch_property_type_info()
* master:
  update NEWS
  Expose missing flags from libzip at least >= 0.11.x
  Fix typo in phpdbg help.
  Add missing newlines to phpdbg's help for the run command.
  Skip test which is 64bits only
  update NEWS
  fix test portability
  prepare for 5.6.22RC1
nikic added 24 commits Jan 3, 2019
We also have to remove ref sources for the immutable class case.
This is handled by the calling code in this case.
Also fix a bug in inference for object properties: We must check
that it's a non-static property, otherwise null becomes an additional
valid return value.
Based on reviewer comment.
This reverts commit 0cc95b8.

This has already been fixed in a different way in
3b830cf and is unrelated to
typed properties...
Still needs more work to make the assignment successful in more
cases.
Taken from PR #3573, minus the foreach/iteration parts.
@nikic nikic force-pushed the bwoebi:typed_ref_properties branch from 7429cb1 to 5f7d376 Jan 7, 2019
@nikic nikic mentioned this pull request Jan 7, 2019
@nikic
Copy link
Member Author

@nikic nikic commented Jan 7, 2019

Closing this PR in favor of #3734, which is the same thing but squashed.

@nikic nikic closed this Jan 7, 2019
php-pulls pushed a commit that referenced this pull request Jan 11, 2019
RFC: https://wiki.php.net/rfc/typed_properties_v2

This is a squash of PR #3734, which is a squash of PR #3313.

Co-authored-by: Bob Weinand <bobwei9@hotmail.com>
Co-authored-by: Joe Watkins <krakjoe@php.net>
Co-authored-by: Dmitry Stogov <dmitry@zend.com>
@ice6
Copy link

@ice6 ice6 commented Apr 3, 2020

what an improvement!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

You can’t perform that action at this time.