Don't overload ArrayObject get_properties #3574
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to fix #3573 (comment).
The first commit lays groundwork to allow proper overloading of
(array)
casts. The second commit explicitly overloads(array)
forArrayObject
and removes theget_properties
overload.The BC breaks are noted in UPGRADING. I think that
array_key_exists()
is the only problematic one. However, as we already plan to deprecate array_key_exists with objects. As this will make the operation generate a warning (rather than silently change behavior) I'm not so concerned.