Remove --disable-opcache-file-cache option

[nikic]

This is no longer an experimental feature, and we have the ability to control this at runtime via an ini setting already. There doesn't seem to be any good reason for also having a compile-time option which requires littering the whole code with HAVE_OPCODE_FILE_CACHE checks. Case in point, the --disable-opcache-file-cache build is currently broken, because such a check was missed in one place.

@dstogov Any objections?

[dstogov]

No objections. Please merge.

[krakjoe]

Merged c32da66

Ta.

[petk]

Do we also add this change also to UPGRADING file? I think it's better to have longer changelog files than searching commit logs where a configure option has been removed and causes configure: WARNING: unrecognized options: --disable-opcache-filecache in the output...

[krakjoe]

Sure, go ahead ... the option removed was disable|enable-opcache-file

[petk]

Upgrading changelog updated via c706a26. Thanks.

[cmb69]

@petk This note should go to UPGRADING, not UPGRADING.INTERNALS.

[petk]

I thought build system changes go there... Under which section should this go to then? Because in the internals file there is a dedicated section for build system changes. And this changes the defined constant in one of the header files which is relevant more for internals developers than PHP developers.

[cmb69]

I thought that UPGRADING.INTERNALS is for extension authors only, so changes to configure options should go into UPGRADING. @nikic even added a new section regarding pkg-config related configure options changes to UPGRADING. This removal could go to the “Other Changes to Extensions” section. Maybe an additional note in UPGRADING.INTERNALS is appropriate, too.

[petk]

Before in the main/php_config.h:

/* Define to enable file based caching (experimental) */
#define HAVE_OPCACHE_FILE_CACHE 1

After this patch in the main/php_config.h this constant is not defined anymore. I'll update both then...

[KalleZ]

I believe it should go into both UPGRADING and UPGRADING.INTERNALS. I did document the changes I did to the hash extension when my RFC passed in UPGRADING only, but I do believe it should also be available in UPGRADING.INTERNALS as some extension authors may find it useful that certain macros may or may no longer be available

[nikic]

@petk The removal of HAVE_OPCACHE_FILE_CACHE does not need to be documented. And yes, changes to configure options go into UPGRADING, as they are user-facing changes.

[petk]

Sounds good. Change coming up to the UPGRADING file only then to the section "Other Changes to Extensions". Important here is that it's just documented somewhere that a configure option has been removed... Thanks for the tips.

- OPcache:
  . The --disable|enable-opcache-file configure options have been removed in
    favor of the opcache.file_cache ini directive.