Add minimum required PHP version to run-tests.php #3986
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This integrates a simple minimum PHP version check in the tool and to also define the minimum version that the tool syntax should support.
nikic
reviewed
Mar 25, 2019
nikic
approved these changes
Mar 26, 2019
|
Applied via 434388a to PHP-7.4+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brought up in the #3981 to make a certain extension case pass and to be able to run tests in parallel on PHP 7.0 versions, however I probably don't need to explain that this is a very bad practice. Since people pushed this change in the code already we at least need to define the minimum constraint to be clear.
For people who are upgrading their code please follow the better recommended practices defined at the supported versions page and use the supported versions: https://www.php.net/supported-versions.php
So, this now adds a minimum PHP requirement constraint in the run-tests.php script.
Thanks.