Litespeed sapi OpenBSD build fix #3999
Conversation
| *off += written; | ||
| return 0; | ||
| } | ||
| #endif |
There was a problem hiding this comment.
Is this sendfile implementation taken from somewhere?
There was a problem hiding this comment.
Not taken, this is just read a file descriptor and writing in another one, I chose a small buffer for starter then increased to gain a little bit but no match for kernel space implementation.
|
Hmm, what's George's Github handle? |
|
|
devnexen
force-pushed
the
litespeed_openbsd_fix
branch
from
14511e6
to
9ad942f
Compare
|
Done with it, at worse DragonflyBSD supports sendfile call just as FreeBSD ... |
|
cc @davidlst |
|
@devnexen can you please update this for master branch ? Since we can test this ourselves now, I'm happy to ship in 8.1 if the build passes ... we'll need CI to build litespeed on fbsd in that case ... |
|
It s OpenBSD the choices of CI for this are even thinner (radare2 for example is able to). On FreeBSD it should build fine as it supports sendfile natively. |
attempt to core dump in the proper place. kernel sendfile feature does not exist so userland implementation for the poor ... no chance to reach the speed of light ...
devnexen
force-pushed
the
litespeed_openbsd_fix
branch
from
9ad942f
to
87df921
Compare
|
Ah, gotcha. So currently, we can't test this, but I assume you have ? I'm happy to take your word for it as our emerging bsd variant expert, if it looks good to you it looks good to me. Is it worth your time to setup that CI ? |
|
nevermind, radare2 seems to have removed the CI support maybe that was not reliable enough. |
|
Okay, but to confirm you've run this through your own tests on the relevant platform, yes ? |
|
yes I did a quick one. |
attempt to core dump in the proper place.
kernel sendfile feature does not exist so
userland implementation for the poor ... no chance
to reach the speed of light ...