Bug44168

[m6w6]

Leeaving that for cataphract

[cataphract]

I still maintain that this option is worse than the status quo, as it will break 206 responses. At the very least an exception should be carved out for that, but probably there are other situations where the Content-length field is mandatory (whereas compression is always optional).

[m6w6]

Where is a Content-Length required? A 206 response surely does not (according to the RFC)

[m6w6]

That may have sounded harsher than intended!

The RFC says to 206:

    Either a Content-Range header field (section 14.16) indicating
    the range included with this response, or a multipart/byteranges
    Content-Type including Content-Range fields for each part. If a
    Content-Length header field is present in the response, its
    value MUST match the actual number of OCTETs transmitted in the
    message-body.

[cataphract]

You're right, it's my statement in the bug report that's incorrect. I guess I meant "Content-Range", which the example also uses, but then the implementation doesn't really match this description because it looks only for "Content-length". So it should look for that header instead (or for a 206 response). Or better, additionally, because:

I would still say that content-length should inhibit compression instead of compression inhibiting content-length. The first is a header that's set by the programmer, the other is a filter some people activate in php.ini. The header is very important for some applications which need to know ahead of time the size of the response (for display progress, to allow seeking, etc.). If the header is to be removed, this should definitely be limited to master.

[cataphract]

By the way, the bug is this one: https://bugs.php.net/bug.php?id=44164 (44164, not 8).

[m6w6]

Alright, so why don't we just close the bug? It's still open, though the "agreed" fix is already in the code? I wrote the patch and just noticed afterwards, that your fix was live already for years :)

[cataphract]

Well, the issue was a bit controversial, so it was just left marinating. I'll close it.

[m6w6]

Thank you! :)