Add extensions naming conventions to ext_skel.php #4155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KalleZ
approved these changes
May 12, 2019
|
LGTM too. |
- first character is a letter - followed by any number of letters - prefferred are lower case letters, but optionally allowed also upper case letters, numbers and underscores.
petk
force-pushed
the
patch-ext-skel-naming-conventions
branch
from
2a549da
to
f8ca7cc
Compare
|
So far, this script now still converts the extension name to lowercase... Yet, PECL site allows creating extension with uppercase letters. pecl install FOO is the same as pecl install foo. :/ |
|
@petk Ah well in that case it is all good :) |
|
Applied then via 44952cd to PHP-7.4+. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Naming conventions, for the new extensions:
Synced with:
https://github.com/php/web-pecl/blob/4eb380c54af31f48d7c41b2b4e427e814b1b5f8d/public_html/package-new.php#L58
and https://bugs.php.net/bug.php?id=77968