Remove unused build checks #4417
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- yp_get_default_domain was part of ext/yp - functions checks produce HAVE_function_name symbols. These checks are currently not used in php-src neither in the extensions out there. - Removed symbols because they are not used in the code: - HAVE_GCVT - HAVE_PUTENV - HAVE_PUTENV - HAVE_SETVBUF - HAVE_TEMPNAM - HAVE_SIN (sin is also defined in C89 standard) - HAVE_SETSOCKOPT - HAVE_LOCKF - HAVE_ISASCII - HAVE_YP_GET_DEFAULT_DOMAIN (and other yp extension related unused checks) - HAVE_USLEEP is already defined in Windows configuration header - HAVE_LIBBIND has not been used in php-src for a while anymore - HAVE_GETHOSTNAME is duplicated in Windows configuration header
- HAVE_LINK is not used
nikic
approved these changes
Jul 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently not used in php-src neither in the extensions out there.