Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote warnings to errors in extract() #4588

Closed
wants to merge 4 commits into from
Closed

Promote warnings to errors in extract() #4588

wants to merge 4 commits into from

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Aug 21, 2019

Split from #4566

@Girgias Girgias mentioned this pull request Aug 21, 2019
Closed
theodorejb
theodorejb reviewed Aug 27, 2019
View reviewed changes
Copy link
Contributor

@theodorejb theodorejb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the return type still int|null? If it is no longer nullable, the proto comment should be updated as well as the stub signature.

@Girgias
Copy link
Member Author

Girgias commented Aug 27, 2019

Is the return type still int|null? If it is no longer nullable, the proto comment should be updated as well as the stub signature.

I don't think it can return null any more so I've updated the stubs.

nikic
nikic requested changes Aug 28, 2019
View reviewed changes
Copy link
Member

@nikic nikic left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, please drop the extra variation tests. The only thing we need is to check the invalid prefix case in the existing error test, the rest just duplicates existing tests.

@Girgias
Copy link
Member Author

Girgias commented Aug 28, 2019

Yeah I forgot those were covered in the normal error ones.

Removed them and merged as 70e604e

@Girgias Girgias closed this Aug 28, 2019
@Girgias Girgias deleted the extract-warnings2error branch August 28, 2019 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SjonHortensius SjonHortensius SjonHortensius left review comments

@theodorejb theodorejb theodorejb left review comments

@nikic nikic nikic requested changes

Assignees
No one assigned
Labels
Warning promotion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Girgias @nikic @SjonHortensius @theodorejb @kocsismate