Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #76584: PharFileInfo::decompress not working #5115

Closed
wants to merge 1 commit into from
Closed

Fix #76584: PharFileInfo::decompress not working #5115

wants to merge 1 commit into from

Conversation

cmb69
Copy link
Contributor

@cmb69 cmb69 commented Jan 26, 2020

We actually have to decompress, when told to do so.

@cmb69
Fix #76584: PharFileInfo::decompress not working
4e08dfc 
We actually have to decompress, when told to do so.
@nikic
Copy link
Member

nikic commented Jan 27, 2020

Looks reasonable, but not familiar with this code.

@cmb69
Copy link
Contributor Author

cmb69 commented Jan 27, 2020

@bishopb, could you please review?

@bishopb
Copy link
Contributor

bishopb commented Jan 27, 2020

Looks good to me. Thanks!

@cmb69
Copy link
Contributor Author

cmb69 commented Jan 28, 2020

Thanks for checking!

Applied as 136f51f.

@cmb69 cmb69 closed this Jan 28, 2020
@cmb69 cmb69 deleted the cmb/fix-76584 branch January 28, 2020 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cmb69 @nikic @bishopb