Allow passing a second argument to gettype to resolve class names #5142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding blessed changes Replaced spaces with tabs Return zend_string without intern Returning copy of name
markrandall
force-pushed
the
extended-gettype
branch
from
4b1b022
to
cac1298
Compare
kocsismate
reviewed
Feb 2, 2020
| ZEND_PARSE_PARAMETERS_END(); | ||
|
|
||
| if (resolve_object_names && Z_TYPE_P(arg) == IS_OBJECT) { | ||
| RETURN_STR_COPY(Z_OBJ_P(arg)->ce->name); |
There was a problem hiding this comment.
One gotcha I see with this solution is the ambiguous result when a resource class instance is passed to get_type(). See https://3v4l.org/5aEd2 for example. I admit though that this is an edge case (and maybe resource should be reserved independently from this PR?).
|
Possible alternative would be another function, maybe describe_type which would give int / float / bool / object(classname) / resource(resname) ? CC @beberlei |
|
Please add a new function, as you'll also want to fix the returned type names. |
|
Implemented as new function in #5143 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.