Require all internal functions to have arginfo #5208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
force-pushed
the
require-arginfo
branch
from
41f1170
to
8851093
Compare
|
I've relaxed this a bit to only throw a warning -- makes it more convenient to see all the missing arginfo reported at once. The main part here is that we interpret no arginfo as the signature with no args, and don't exclude it from LSP checks. |
nikic
force-pushed
the
require-arginfo
branch
from
8851093
to
f048ab5
Compare
|
@cmb69 Can you please take a look at the last commit? |
nikic
force-pushed
the
require-arginfo
branch
from
f048ab5
to
a150766
Compare
|
Merged as b35b014. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All internal functions are now required to specify arg_info.
Note that zf->common.arg_info can still be NULL, but only if num_args==0.