Improve some ValueError messages #5340
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
commented
Apr 2, 2020
| @@ -917,12 +917,12 @@ PHP_FUNCTION(imagecreatetruecolor) | |||
| } | |||
|
|
|||
| if (x_size <= 0 || x_size >= INT_MAX) { | |||
| zend_value_error("Invalid width (x_size)"); | |||
There was a problem hiding this comment.
I'm not sure if showing the exact interval would be better
There was a problem hiding this comment.
Saying greater than 0 should be fine IMHO
Girgias
reviewed
Apr 2, 2020
| @@ -917,12 +917,12 @@ PHP_FUNCTION(imagecreatetruecolor) | |||
| } | |||
|
|
|||
| if (x_size <= 0 || x_size >= INT_MAX) { | |||
| zend_value_error("Invalid width (x_size)"); | |||
There was a problem hiding this comment.
Saying greater than 0 should be fine IMHO
| @@ -10,4 +10,4 @@ try { | |||
| } | |||
| ?> | |||
| --EXPECT-- | |||
| Unknown value 1000 | |||
| assert_options(): Argument #1 ($what) must have a valid value | |||
There was a problem hiding this comment.
That's an interesting argument name
nikic
reviewed
Apr 3, 2020
nikic
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.