Promote some warnings in MBString Regex #5341
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
Apr 3, 2020
Girgias
force-pushed
the
mbstring-regex-warnings-to-error
branch
from
c9a14a3
to
2ad2671
Compare
Girgias
commented
Apr 3, 2020
Comment on lines
+15
to
+24
| try { | ||
| $var13 = mb_ereg_search_pos(); | ||
| } catch (\Error $e) { | ||
| echo $e->getMessage() . \PHP_EOL; | ||
| } | ||
| ?> | ||
| --EXPECTF-- | ||
| Warning: mb_ereg_search_pos(): No regex given in %sbug72399.php on line %d | ||
| --EXPECT-- | ||
| bool(true) | ||
| string(0) "" | ||
| No pattern was provided |
There was a problem hiding this comment.
I really don't get why this throws, will need to investigate I suppose.
There was a problem hiding this comment.
I don't know was confused, probably because I suppose it should throw before? As in in mb_ereg_search_init() ?
Girgias
force-pushed
the
mbstring-regex-warnings-to-error
branch
2 times, most recently
from
7903ef5
to
54b6ac2
Compare
Girgias
force-pushed
the
mbstring-regex-warnings-to-error
branch
from
54b6ac2
to
8092994
Compare
Girgias
force-pushed
the
mbstring-regex-warnings-to-error
branch
from
8092994
to
2aa6653
Compare
kocsismate
reviewed
Aug 1, 2020
|
I think another PR also did something in this area, can you please rebase? |
nikic
reviewed
Aug 6, 2020
nikic
reviewed
Aug 6, 2020
Girgias
force-pushed
the
mbstring-regex-warnings-to-error
branch
from
2aa6653
to
5d36f8a
Compare
71 tasks
nikic
reviewed
Sep 8, 2020
Girgias
force-pushed
the
mbstring-regex-warnings-to-error
branch
from
5d36f8a
to
fcd52e5
Compare
nikic
reviewed
Sep 8, 2020
Comment on lines
+15
to
+24
| try { | ||
| $var13 = mb_ereg_search_pos(); | ||
| } catch (\Error $e) { | ||
| echo $e->getMessage() . \PHP_EOL; | ||
| } | ||
| ?> | ||
| --EXPECTF-- | ||
| Warning: mb_ereg_search_pos(): No regex given in %sbug72399.php on line %d | ||
| --EXPECT-- | ||
| bool(true) | ||
| string(0) "" | ||
| No pattern was provided |
Girgias
force-pushed
the
mbstring-regex-warnings-to-error
branch
from
fcd52e5
to
fdac9bd
Compare
nikic
approved these changes
Sep 9, 2020
| @@ -651,14 +651,16 @@ _php_mb_regex_init_options(const char *parg, size_t narg, OnigOptionType *option | |||
| *syntax = ONIG_SYNTAX_POSIX_EXTENDED; | |||
| break; | |||
| case 'e': | |||
| if (eval != NULL) *eval = 1; | |||
| break; | |||
| zend_value_error("Option \"e\" is not supported"); | |||
There was a problem hiding this comment.
You can remove this as a separate case (handle in default). Or alternatively, use a different error message like "no longer supported".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm clueless on some of them if they should be converted or not.