Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Named params implementation #5357

Closed
wants to merge 31 commits into from
Closed

Named params implementation #5357

wants to merge 31 commits into from

Commits on Jul 31, 2020

  1. Partial named params implementation

    @nikic
    nikic committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    424f0b6 View commit details
    Browse the repository at this point in the history

  2. Check for duplicate parameter names in internal functions

    @nikic
    nikic committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    4afe5b4 View commit details
    Browse the repository at this point in the history

  3. Add AST export support

    @nikic
    nikic committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    a8e7462 View commit details
    Browse the repository at this point in the history

  4. Fix test name

    @nikic
    nikic committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    8b14583 View commit details
    Browse the repository at this point in the history

  5. Add tests for Attribut(flags: ) 

    This doesn't work correctly yet.
    @nikic
    nikic committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    75964c0 View commit details
    Browse the repository at this point in the history

  6. Only check for undef in RECV(_INIT) 

    As we initialize CVs to undef, we don't need to check for both
argument count and undef here, the latter is enough.
    @nikic
    nikic committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    e550f4a View commit details
    Browse the repository at this point in the history

  7. Check for undef in recv jit 

    Rather than checking the argument count
    @nikic
    nikic committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    d346bbd View commit details
    Browse the repository at this point in the history

  8. Add flag to distinguish named fcalls

    @nikic
    nikic committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    8bdd1a9 View commit details
    Browse the repository at this point in the history

  9. SEND may throw for named params

    @nikic
    nikic committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    883c0a5 View commit details
    Browse the repository at this point in the history

  10. For unpacks, we should also assume there may be named args

    @nikic
    nikic committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    3683f0e View commit details
    Browse the repository at this point in the history

  11. Free extra named args in jit

    @nikic
    nikic committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    368500b View commit details
    Browse the repository at this point in the history

  12. Initialize icall undef args in jit

    @nikic
    nikic committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    d0492b1 View commit details
    Browse the repository at this point in the history

  13. Always emit type check in RECV_INIT 

    If named parameters are used, we never jump over these opcodes.
    @nikic
    nikic committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    bb79eed View commit details
    Browse the repository at this point in the history

  14. Fix attribtue tests for new syntax

    @nikic
    nikic committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    268b69c View commit details
    Browse the repository at this point in the history

  15. WIP

    @nikic
    nikic committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    fc37bc0 View commit details
    Browse the repository at this point in the history

  16. Fixes

    @nikic
    nikic committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    5fddc6f View commit details
    Browse the repository at this point in the history

  17. Cleanup

    @nikic
    nikic committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    06a4ab7 View commit details
    Browse the repository at this point in the history

  18. jit

    @nikic
    nikic committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    a46694c View commit details
    Browse the repository at this point in the history

  19. Fix windows?

    @nikic
    nikic committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    1aec287 View commit details
    Browse the repository at this point in the history

  20. Rename opcode to be more precise 

    This opcode is only needed if there are undef args and may be
dropped otherwise (even though there are named args).
    @nikic
    nikic committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    a164e5d View commit details
    Browse the repository at this point in the history

  21. Make flag meaning more precise 

    Separately track the concept of "undef args" and "extra args",
to make this more amenable to future optimization.
    @nikic
    nikic committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    90dac08 View commit details
    Browse the repository at this point in the history

  22. Make compiler code a bit smarter

    @nikic
    nikic committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    a9a0252 View commit details
    Browse the repository at this point in the history

  23. Move function back to where it was

    @nikic
    nikic committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    2700037 View commit details
    Browse the repository at this point in the history

  24. Rename function to match opcode name

    @nikic
    nikic committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    0f9131e View commit details
    Browse the repository at this point in the history

  25. jit cleanup

    @nikic
    nikic committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    141ded0 View commit details
    Browse the repository at this point in the history

  26. Support extra named params in backtraces

    @nikic
    nikic committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    077886d View commit details
    Browse the repository at this point in the history

  27. Prepare for extra named params reuse 

    Use a helper and release the array rather than destroying it,
as it may have rc>1 in the future.
    @nikic
    nikic committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    3e45549 View commit details
    Browse the repository at this point in the history

  28. Reuse extra_named_params if possible

    @nikic
    nikic committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    e77c2b6 View commit details
    Browse the repository at this point in the history

  29. Combine check for extra named params and allocated call

    @nikic
    nikic committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    e31838a View commit details
    Browse the repository at this point in the history

  30. Drop one of the free extra named params helpers 

    Most places now need a custom call_info check, this is not
worthwhile.
    @nikic
    nikic committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    ed108d4 View commit details
    Browse the repository at this point in the history

  31. Revert an incorrect change 

    The frame is freed separately here.
    @nikic
    nikic committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    a6b566d View commit details
    Browse the repository at this point in the history