-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #79532: sizeof off_t can be wrong #5482
Conversation
We have to actually determine the proper `SIZEOF_OFF_T`.
Added test fails on travis. |
Thanks! Should be fixed now. |
@cmb69 Including pg_config.h seems super fishy. It looks like libpq supports PQlibVersion() since 9.1, we should switch to using that instead of PG_VERSION. |
ACK. However, while we could construct |
@cmb69 For now, please add an |
The clean solution would likely be to not include pg_config.h at all, but that's out of scope for BC reasons for now.
Okay, makes sense. I'll have a closer look at the PostgreSQL issue later. |
Thanks! Applied as 67f9b0b. |
We have to actually determine the proper
SIZEOF_OFF_T
.