Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Implement nullsafe ?-> operator #5619

Closed
wants to merge 25 commits into from
Closed

[WIP] Implement nullsafe ?-> operator #5619

wants to merge 25 commits into from

Commits on Jul 22, 2020

  1. Implement nullsafe ?-> operator

    @iluuu1994 @nikic
    iluuu1994 authored and nikic committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    638bcfe View commit details
    Browse the repository at this point in the history

  2. Disallow ?-> in write context

    @iluuu1994 @nikic
    iluuu1994 authored and nikic committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    9757ee0 View commit details
    Browse the repository at this point in the history

  3. Compile error when taking ref of ?-> chain

    @iluuu1994 @nikic
    iluuu1994 authored and nikic committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    88aa39a View commit details
    Browse the repository at this point in the history

  4. Fix isset() directly on nullsafe 

    We should still treat nullsafe as a variable, just not a writable
variable.
    @nikic
    nikic committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    6acd29c View commit details
    Browse the repository at this point in the history

  5. Add test case for nullsafe in foreach by ref

    @nikic
    nikic committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    77e60ce View commit details
    Browse the repository at this point in the history

  6. Add nullsafe in foreach target test

    @iluuu1994 @nikic
    iluuu1994 authored and nikic committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    d850f13 View commit details
    Browse the repository at this point in the history

  7. Don't convert foreach on nullsafe as ref

    @nikic
    nikic committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    e7b2751 View commit details
    Browse the repository at this point in the history

  8. Fix SCCP on JMP_NULL

    @nikic
    nikic committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    b7fdb62 View commit details
    Browse the repository at this point in the history

  9. Optimize JMP_NULL in dfa_pass

    @nikic
    nikic committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    3e25a35 View commit details
    Browse the repository at this point in the history

  10. Correct e-ssa pi node placement for jmp_null

    @nikic
    nikic committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    2dba89d View commit details
    Browse the repository at this point in the history

  11. Handle JMP_NULL in one more place

    @nikic
    nikic committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    fb20008 View commit details
    Browse the repository at this point in the history

  12. Remvoe added phar.tar file 

    Presumably not intentional?
    @nikic
    nikic committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    a7d0505 View commit details
    Browse the repository at this point in the history

  13. Remove short-circuit handling for assignments 

    I don't believe this is needed anymore under the new semantics.
    @nikic
    nikic committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    83c56b2 View commit details
    Browse the repository at this point in the history

  14. Undo some more changes 

    This is fine either way, but let's reduce the diff.
    @nikic
    nikic committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    7f9644d View commit details
    Browse the repository at this point in the history

  15. Fix nullsafe chain in varvar

    @nikic
    nikic committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    0f8fce5 View commit details
    Browse the repository at this point in the history

  16. Correctly handle static property / method name

    @nikic
    nikic committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    efe2cc7 View commit details
    Browse the repository at this point in the history

  17. Add test file 

    Forgot to git add this.
    @nikic
    nikic committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    207f7a3 View commit details
    Browse the repository at this point in the history

  18. Alternative implementation for short-circuiting

    @nikic
    nikic committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    4f2bf30 View commit details
    Browse the repository at this point in the history

  19. Make opcache test i386 compatible

    @nikic
    nikic committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    b12abdb View commit details
    Browse the repository at this point in the history

  20. Use ZVAL_TRUE/FALSE macros

    @nikic
    nikic committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    230eb9e View commit details
    Browse the repository at this point in the history

  21. Remove redundant return

    @nikic
    nikic committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    9eae721 View commit details
    Browse the repository at this point in the history

  22. Use more efficient argument passing opcode if possible

    @nikic
    nikic committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    44cbf31 View commit details
    Browse the repository at this point in the history

  23. Remove unnecessary FREE_OP1(), reduce specialization

    @nikic
    nikic committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    7cbe31e View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2020

  1. Improve nullsafe in binary op tests

    @iluuu1994
    iluuu1994 committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    9dd99c8 View commit details
    Browse the repository at this point in the history

  2. Add tests for ?-> in sub-chain by ref

    @iluuu1994
    iluuu1994 committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    3af4df8 View commit details
    Browse the repository at this point in the history